Files
ForgeBucket/internal/api/router.go
T
erangel1 edf3c9824e Phase 3C — Commit Summary
feat: workspaces — collaborative repo namespaces
Backend
- internal/models/workspace.go — Workspace (handle, displayName,
  description, createdBy) + WorkspaceMember (workspaceId, userId,
  username, role: owner/admin/member)
- internal/models/repo.go — added nullable workspace_id column; existing
  user repos unaffected
- internal/models/migrations/011_workspaces.go — syncs both tables +
  adds column to repository
- internal/api/handlers/workspace.go — ListWorkspaces, CreateWorkspace,
  GetWorkspace, UpdateWorkspace, DeleteWorkspace (blocks if repos
  remain), ListRepos, ListMembers, AddMember, UpdateMember, RemoveMember
- internal/api/handlers/repos.go — lookupRepo resolves workspace
  handles; Create accepts workspace field; List includes workspace
  member repos; withOwnerName uses workspace handle for workspace-owned
  repos
- internal/api/handlers/dashboard.go — recentRuns + repo list include
  workspace repos the user is a member of
- internal/api/router.go — /workspaces, /workspaces/:handle/* routes
  Workspace rules enforced:
- Handle globally unique across usernames + workspace handles (409 on
  collision)
- Creator auto-assigned owner role
- Delete blocked if repos exist
- Last owner cannot be demoted/removed
  ---
  feat: secret management hierarchy (Global → Workspace → Repo → Env)
  Backend
- internal/models/secret.go — Secret struct +
  EncryptSecret/DecryptSecret with AES-256-GCM (key = SHA-256 of
  SESSION_SECRET); values never serialised to JSON
- internal/models/migrations/012_secrets.go — syncs secret table
- internal/api/handlers/secret.go — List/Upsert/Delete for all four
  scopes; ResolveSecretsForRun builds merged env map for CI
- internal/domain/ci/executor.go — JobContext.Secrets field; secrets
  injected as --env KEY=VALUE into docker run; buildJobContext calls
  resolveSecrets(Global < Workspace < Repo < Env)
- internal/domain/ci/runner_manager.go — passes cfg.SessionSecret to
  buildJobContext
- internal/api/router.go — /repos/:owner/:repo/secrets,
  /environments/:envName/secrets, /workspaces/:handle/secrets,
  /admin/secrets
  ---
  feat: workspace + secret management UI
  Frontend
- types/api.ts — Workspace, WorkspaceWithMeta, WorkspaceMember,
  SecretListItem types
- api/queries/workspaces.ts — full CRUD hooks + WorkspaceRepo type
- api/queries/secrets.ts — repo/env/workspace secret hooks
- pages/WorkspacesPage.tsx — list + create modal
- pages/WorkspacePage.tsx — workspace dashboard with repo list
- pages/WorkspaceSettingsPage.tsx — general settings, members CRUD,
  workspace secrets, danger zone
- pages/RepoSecretsPage.tsx — repo secrets + per-environment secret
  sections with priority hierarchy callout
- pages/CreateRepoPage.tsx — ?workspace= query param pre-fills owner
  selector; only admin/owner workspaces shown
- components/layout/Sidebar.tsx — "Workspaces" global nav item +
  workspace quick-links; "Secrets" in RepoSubNav; new SecretsIcon,
  WorkspaceIcon
- App.tsx — routes for /workspaces, /workspaces/:handle,
  /workspaces/:handle/settings, /repos/:owner/:repo/secrets
2026-05-11 23:34:46 +02:00

310 lines
12 KiB
Go

package api
import (
"encoding/json"
"io/fs"
"net/http"
"net/http/httputil"
"net/url"
"strings"
"github.com/go-chi/chi/v5"
chimiddleware "github.com/go-chi/chi/v5/middleware"
"github.com/go-chi/cors"
"github.com/gorilla/sessions"
"xorm.io/xorm"
"github.com/forgeo/forgebucket/internal/api/handlers"
"github.com/forgeo/forgebucket/internal/api/middleware"
"github.com/forgeo/forgebucket/internal/config"
"github.com/forgeo/forgebucket/internal/events"
)
func New(cfg *config.Config, engine *xorm.Engine, store sessions.Store, bus events.EventBus, artifactRoot string, staticFiles fs.FS) http.Handler {
r := chi.NewRouter()
r.Use(chimiddleware.Logger)
r.Use(chimiddleware.RealIP)
r.Use(chimiddleware.Recoverer)
r.Use(cors.Handler(cors.Options{
AllowedOrigins: []string{"http://localhost:5173", cfg.InstanceURL},
AllowedMethods: []string{"GET", "POST", "PUT", "PATCH", "DELETE", "OPTIONS"},
AllowedHeaders: []string{"Accept", "Authorization", "Content-Type", "X-CSRF-Token"},
AllowCredentials: true,
MaxAge: 300,
}))
csrf := middleware.CSRF(!cfg.Debug)
auth := middleware.NewAuth(store, engine, handlers.LookupAccessToken)
audit := middleware.AuditLog(engine, bus)
repoH := handlers.NewRepoHandler(engine, cfg)
userH := handlers.NewUserHandler(engine, store)
prH := handlers.NewPRHandler(engine)
pipeH := handlers.NewPipelineHandler(engine)
wsH := handlers.NewWSHandler(bus)
gitH := handlers.NewGitHTTPHandler(engine, cfg, bus)
issueH := handlers.NewIssueHandler(engine)
sshKeyH := handlers.NewSSHKeyHandler(engine)
memberH := handlers.NewMemberHandler(engine)
keyH := handlers.NewDeployKeyHandler(engine)
tokenH := handlers.NewAccessTokenHandler(engine)
workflowH := handlers.NewWorkflowHandler(engine)
webhookH := handlers.NewWebhookHandler(engine)
prSettingsH := handlers.NewPRSettingsHandler(engine)
lfsH := handlers.NewLFSHandler(engine)
exploreH := handlers.NewExploreHandler(engine)
dashH := handlers.NewDashboardHandler(engine)
auditH := handlers.NewAuditHandler(engine)
artifactH := handlers.NewArtifactHandler(engine, artifactRoot)
runnerH := handlers.NewRunnerHandler(engine)
envH := handlers.NewEnvironmentHandler(engine, bus)
timelineH := handlers.NewTimelineHandler(engine, cfg.RepoRoot)
workspaceH := handlers.NewWorkspaceHandler(engine, cfg)
secretH := handlers.NewSecretHandler(engine, cfg.SessionSecret)
// ── Git smart-HTTP transport ───────────────────────────────────────────────
// Regex constraint ensures only *.git paths match, so asset/SPA URLs
// with two path segments (e.g. /assets/main.js) fall through to the
// SPA catch-all instead of being swallowed here.
r.Route("/{owner}/{repoGit:.*\\.git}", func(r chi.Router) {
r.Get("/info/refs", gitH.ServeGit)
r.Post("/git-upload-pack", gitH.ServeGit)
r.Post("/git-receive-pack", gitH.ServeGit)
})
r.Route("/api/v1", func(r chi.Router) {
// ── Public ────────────────────────────────────────────────────────────
r.Get("/explore/repos", exploreH.Repos)
r.Get("/explore/users", exploreH.Users)
r.Get("/health", func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("Content-Type", "application/json")
w.Write([]byte(`{"status":"ok"}`))
})
// Generates a CSRF token + cookie. SPA calls this once on load.
r.Get("/csrf", func(w http.ResponseWriter, r *http.Request) {
token, err := middleware.NewCSRFToken(w, !cfg.Debug)
if err != nil {
http.Error(w, `{"error":"could not generate CSRF token"}`, http.StatusInternalServerError)
return
}
w.Header().Set("Content-Type", "application/json")
json.NewEncoder(w).Encode(map[string]string{"token": token})
})
// ── Auth (CSRF validated, no session required) ─────────────────────────
r.With(csrf).Post("/auth/register", userH.Register)
r.With(csrf).Post("/auth/login", userH.Login)
r.With(csrf).Post("/auth/logout", userH.Logout)
// ── Protected (session + CSRF for mutations) ──────────────────────────
r.Group(func(r chi.Router) {
r.Use(auth.Require)
r.Use(audit)
r.Get("/me", userH.Me)
r.Get("/dashboard", dashH.Get)
r.Get("/audit", auditH.List)
r.Get("/pipelines/runs", pipeH.ListRecentRuns)
// Workspace routes
r.Get("/workspaces", workspaceH.ListWorkspaces)
r.With(csrf).Post("/workspaces", workspaceH.CreateWorkspace)
r.Route("/workspaces/{handle}", func(r chi.Router) {
r.Get("/", workspaceH.GetWorkspace)
r.With(csrf).Patch("/", workspaceH.UpdateWorkspace)
r.With(csrf).Delete("/", workspaceH.DeleteWorkspace)
r.Get("/repos", workspaceH.ListRepos)
r.Route("/members", func(r chi.Router) {
r.Get("/", workspaceH.ListMembers)
r.With(csrf).Post("/", workspaceH.AddMember)
r.With(csrf).Patch("/{username}", workspaceH.UpdateMember)
r.With(csrf).Delete("/{username}", workspaceH.RemoveMember)
})
r.Get("/secrets", secretH.ListWorkspaceSecrets)
r.With(csrf).Post("/secrets", secretH.UpsertWorkspaceSecret)
r.With(csrf).Delete("/secrets/{name}", secretH.DeleteWorkspaceSecret)
})
// Global secrets (admin)
r.Get("/admin/secrets", secretH.ListGlobalSecrets)
r.With(csrf).Post("/admin/secrets", secretH.UpsertGlobalSecret)
r.With(csrf).Delete("/admin/secrets/{name}", secretH.DeleteGlobalSecret)
r.Route("/admin", func(r chi.Router) {
r.Get("/runners", runnerH.List)
r.With(csrf).Post("/runners/register", runnerH.Register)
})
// SSH key management
r.Get("/user/keys", sshKeyH.List)
r.With(csrf).Post("/user/keys", sshKeyH.Add)
r.With(csrf).Delete("/user/keys/{keyID}", sshKeyH.Delete)
r.Route("/repos", func(r chi.Router) {
r.Get("/", repoH.List)
r.With(csrf).Post("/", repoH.Create)
r.With(csrf).Post("/import", repoH.Import)
r.Route("/{owner}/{repo}", func(r chi.Router) {
r.Get("/", repoH.Get)
r.With(csrf).Patch("/", repoH.Update)
r.With(csrf).Delete("/", repoH.Delete)
r.Get("/tree", repoH.Tree)
r.Get("/avatar", repoH.GetAvatar)
r.With(csrf).Post("/avatar", repoH.UploadAvatar)
r.Get("/blob", repoH.Blob)
r.With(csrf).Put("/blob", repoH.UpdateBlob)
r.Get("/commits", repoH.Commits)
r.Get("/branches", repoH.Branches)
r.Get("/diff", repoH.Diff)
r.Route("/pulls", func(r chi.Router) {
r.Get("/", prH.List)
r.With(csrf).Post("/", prH.Create)
r.Get("/{prID}", prH.Get)
r.With(csrf).Patch("/{prID}", prH.Update)
r.With(csrf).Post("/{prID}/merge", prH.Merge)
r.With(csrf).Post("/{prID}/close", prH.Close)
r.With(csrf).Post("/{prID}/reopen", prH.Reopen)
})
r.Route("/issues", func(r chi.Router) {
r.Get("/", issueH.List)
r.With(csrf).Post("/", issueH.Create)
r.Get("/{issueNum}", issueH.Get)
r.With(csrf).Post("/{issueNum}/close", issueH.Close)
r.With(csrf).Post("/{issueNum}/reopen", issueH.Reopen)
})
r.Get("/pipelines", pipeH.ListPipelines)
r.Route("/runs", func(r chi.Router) {
r.Get("/", pipeH.ListRuns)
r.Route("/{runID}", func(r chi.Router) {
r.Get("/", pipeH.GetRun)
r.With(csrf).Post("/cancel", pipeH.CancelRun)
r.Route("/jobs/{jobID}", func(r chi.Router) {
r.Get("/logs", pipeH.GetJobLogs)
r.With(csrf).Post("/retry", pipeH.RetryJob)
})
r.Get("/artifacts", artifactH.List)
r.With(csrf).Post("/artifacts", artifactH.Upload)
})
})
r.Get("/artifacts/{artifactID}/download", artifactH.Download)
r.Route("/members", func(r chi.Router) {
r.Get("/", memberH.List)
r.With(csrf).Post("/", memberH.Add)
r.With(csrf).Patch("/{username}", memberH.UpdatePermission)
r.With(csrf).Delete("/{username}", memberH.Remove)
})
r.Route("/keys", func(r chi.Router) {
r.Get("/", keyH.List)
r.With(csrf).Post("/", keyH.Create)
r.With(csrf).Delete("/{keyID}", keyH.Delete)
})
r.Route("/tokens", func(r chi.Router) {
r.Get("/", tokenH.List)
r.With(csrf).Post("/", tokenH.Create)
r.With(csrf).Delete("/{tokenID}", tokenH.Delete)
})
r.Route("/branch-protections", func(r chi.Router) {
r.Get("/", workflowH.ListBranchProtections)
r.With(csrf).Post("/", workflowH.CreateBranchProtection)
r.With(csrf).Patch("/{bpID}", workflowH.UpdateBranchProtection)
r.With(csrf).Delete("/{bpID}", workflowH.DeleteBranchProtection)
})
r.Get("/branching-model", workflowH.GetBranchingModel)
r.With(csrf).Put("/branching-model", workflowH.UpdateBranchingModel)
r.Get("/merge-strategies", workflowH.GetMergeStrategies)
r.With(csrf).Put("/merge-strategies", workflowH.UpdateMergeStrategies)
r.Route("/webhooks", func(r chi.Router) {
r.Get("/", webhookH.List)
r.With(csrf).Post("/", webhookH.Create)
r.With(csrf).Patch("/{whID}", webhookH.Update)
r.With(csrf).Delete("/{whID}", webhookH.Delete)
r.With(csrf).Post("/{whID}/test", webhookH.Test)
})
r.Route("/default-reviewers", func(r chi.Router) {
r.Get("/", prSettingsH.ListDefaultReviewers)
r.With(csrf).Post("/", prSettingsH.AddDefaultReviewer)
r.With(csrf).Delete("/{username}", prSettingsH.RemoveDefaultReviewer)
})
r.Get("/default-description", prSettingsH.GetDefaultDescription)
r.With(csrf).Put("/default-description", prSettingsH.UpdateDefaultDescription)
r.Get("/excluded-files", prSettingsH.GetExcludedFiles)
r.With(csrf).Put("/excluded-files", prSettingsH.UpdateExcludedFiles)
r.Get("/timeline", timelineH.GetTimeline)
r.Get("/secrets", secretH.ListRepoSecrets)
r.With(csrf).Post("/secrets", secretH.UpsertRepoSecret)
r.With(csrf).Delete("/secrets/{name}", secretH.DeleteRepoSecret)
r.Get("/lfs-settings", lfsH.Get)
r.With(csrf).Put("/lfs-settings", lfsH.Update)
r.Route("/environments", func(r chi.Router) {
r.Get("/", envH.ListEnvironments)
r.With(csrf).Post("/", envH.CreateEnvironment)
r.Route("/{envName}", func(r chi.Router) {
r.Get("/", envH.GetEnvironment)
r.With(csrf).Patch("/", envH.UpdateEnvironment)
r.With(csrf).Delete("/", envH.DeleteEnvironment)
r.Route("/deployments", func(r chi.Router) {
r.Get("/", envH.ListDeployments)
r.With(csrf).Post("/", envH.CreateDeployment)
r.With(csrf).Patch("/{deployID}/status", envH.UpdateDeploymentStatus)
})
r.Get("/secrets", secretH.ListEnvSecrets)
r.With(csrf).Post("/secrets", secretH.UpsertEnvSecret)
r.With(csrf).Delete("/secrets/{name}", secretH.DeleteEnvSecret)
})
})
})
})
})
})
r.With(auth.Optional).Get("/ws", wsH.Hub)
// In debug mode proxy non-API routes to the Vite dev server so :8080 works too.
// In production the built React app is embedded and served from staticFiles.
if cfg.Debug {
r.Handle("/*", viteProxy("http://localhost:5173"))
} else {
r.Handle("/*", spaHandler(staticFiles))
}
return r
}
func viteProxy(target string) http.Handler {
proxy := &httputil.ReverseProxy{
Rewrite: func(r *httputil.ProxyRequest) {
r.SetURL(mustParseURL(target))
r.Out.Host = r.In.Host
},
}
return proxy
}
func mustParseURL(raw string) *url.URL {
u, err := url.Parse(raw)
if err != nil {
panic(err)
}
return u
}
func spaHandler(staticFiles fs.FS) http.Handler {
fileServer := http.FileServer(http.FS(staticFiles))
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
// fs.FS paths must not have a leading slash.
path := strings.TrimPrefix(r.URL.Path, "/")
if path == "" {
path = "."
}
_, err := staticFiles.Open(path)
if err != nil {
r.URL.Path = "/"
}
fileServer.ServeHTTP(w, r)
})
}